Skip to content

Provide an xworker to PyEditors #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

Provide an xworker to PyEditors #2216

merged 1 commit into from
Oct 9, 2024

Conversation

WebReflection
Copy link
Contributor

Description

This MR goal is to fix #2215 by providing a way, for advanced users, to terminate a worker once an editor has been removed from the DOM.

Changes

  • lazily expose the xworker once created
  • test manually that everything works as expected

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

@WebReflection WebReflection requested a review from ntoll October 9, 2024 09:21
@WebReflection WebReflection merged commit 722abda into pyscript:main Oct 9, 2024
2 checks passed
WebReflection added a commit that referenced this pull request Oct 10, 2024
@WebReflection
Provide an xworker to PyEditors (#2216)
5f52649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntoll ntoll ntoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebReflection @ntoll