Fix #2220 - Delay plugins resolution due Safari 17.6 greedy resolution #2229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR goal is to fix #2220 which took me ages to investigate but basically the issue is that Safari resolve plugins in a greedier manner than other browsers so that somehow the
core.js
module that is the one asynchronously requesting theerror.js
plugin could've been still parsing synchronously stuff while theerror.js
would've asked tocore.js
details.Basically the ECMAScript Module Resolution is currently broken on Safari and the current enforcement finally removed that ugly error state in
error.js
.This MR also fixes #2228 by updating an already published and tested Polyfill which also brings in latest versions of both Pyodide and MicroPython.
Changes
for
loop even if it was never blocking for exactly this reason, but plugins where instantly resolved right before and still asynchronouslyChecklist
make build
works locally.