Skip to content

Fix #2220 - Delay plugins resolution due Safari 17.6 greedy resolution #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

WebReflection
Copy link
Contributor

@WebReflection WebReflection commented Oct 24, 2024

Description

This MR goal is to fix #2220 which took me ages to investigate but basically the issue is that Safari resolve plugins in a greedier manner than other browsers so that somehow the core.js module that is the one asynchronously requesting the error.js plugin could've been still parsing synchronously stuff while the error.js would've asked to core.js details.

Basically the ECMAScript Module Resolution is currently broken on Safari and the current enforcement finally removed that ugly error state in error.js.

This MR also fixes #2228 by updating an already published and tested Polyfill which also brings in latest versions of both Pyodide and MicroPython.

Changes

  • delay plugins resolution during the for loop even if it was never blocking for exactly this reason, but plugins where instantly resolved right before and still asynchronously
  • update polyscript to its latest

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

@WebReflection WebReflection force-pushed the issue-2220-round-2 branch 2 times, most recently from e2850a3 to abb20d1 Compare October 24, 2024 11:29
@WebReflection WebReflection changed the title Fix #2220 - Make the minifier happier Fix #2220 - Delay plugins resolution due Safari 17.6 greedy resolution Oct 24, 2024
@WebReflection
Copy link
Contributor Author

WebReflection commented Oct 24, 2024

This version has been published as https://cdn.jsdelivr.net/npm/@pyscript/core@0.6.13/dist/core.js and its CSS counter-part.

@WebReflection WebReflection requested a review from ntoll October 24, 2024 11:34
@WebReflection WebReflection merged commit 9233d5e into pyscript:main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V0.6.x micropip often fails to discover package Can't disable stderr DOM redirection
2 participants