Update the size of the Py icon on the release page template #2232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rks in a mobile friendly manner.
|
I believe the sooner we switch to CSS media queries the better but for the time being this looks OKish to me ... do you want me to suggest a better change? Happy to do so, otherwise I can tackle this after landing it. |
|
something like this should do: #header > svg {
width: 512px;
height: 173px;
}
@media only screen and (max-width : 400px) {
#header > svg {
width: 256px;
height: 87px;
}
}edit P.S. this requires you to remove |
WebReflection
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PyScript logo on release pages was too big for mobile devices.
Changes
This PR changes the size of the logo so it works well on mobile and desktop.
Checklist
make buildworks locally.