Skip to content

Factored out codemirror as chunked lazy based import #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 26, 2024
Merged

Factored out codemirror as chunked lazy based import #2252

merged 3 commits into from
Nov 26, 2024

Conversation

WebReflection
Copy link
Contributor

Description

This MR moves inline, list-ordered, codemirror related lazy imports in a way that's easy to share through the project or its users.

Changes

  • name all codemirror runtime imports as object literal field
  • export that literal via pyscript module too so that other projects could reuse our same modules

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

@WebReflection WebReflection requested a review from ntoll November 20, 2024 11:50
ntoll
ntoll approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@WebReflection WebReflection merged commit 7e65836 into pyscript:main Nov 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntoll ntoll ntoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebReflection @ntoll