Fix #2246 - Override builtins.input to avoid duplicating it #2254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published as |
JoshuaLowe1002
approved these changes
Nov 25, 2024
5f69f0d to
73f43fb
Compare
73f43fb to
12fcef4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR fixes #2246 by overriding the
builtins.inputapparently needed to avoid duplicated text on constrained terminal width where apparentlysetStdinis not enough and an extra override is needed for the builtins as we used to do in classic.Thanks @JoshuaLowe1002 for the hint around it, this has been manually successfully tested too.
Changes
builtins.inputwhen the terminal runs in a workercode.interact()aroundChecklist
make buildworks locally.