Skip to content

Add conda as a make setup option #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2025
Merged

Add conda as a make setup option #2305

merged 2 commits into from
Mar 20, 2025

Conversation

danyeaw
Copy link
Collaborator

@danyeaw danyeaw commented Feb 28, 2025

Description

This PR goes along with pyscript/docs#175 to make it possible to use a conda environment for development of pyscript.

Changes

If VIRTUAL_ENV isn't defined, checks if CONDA_PREFIX is instead.

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

ntoll
ntoll approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@WebReflection WebReflection merged commit 46ca915 into pyscript:main Mar 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntoll ntoll ntoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danyeaw @ntoll @WebReflection