-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add initial dev setup automation #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions related to conda run
.PHONY: shell | ||
shell: | ||
@export CONDA_ENV_PROMPT='<{name}>' | ||
@echo 'conda activate $(env)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been unable to coerce this into working in other repos. As-is, this is a no-op echo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if you are + or - on this one :D
This specific cmd is not that relevant anymore(and I think I'll remove it) no that we want to default using conda run
... right? Or am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was indirectly suggesting we remove it, unless you have a way to make it work :)
pyscriptjs/Makefile
Outdated
.PHONY: setup | ||
setup: | ||
@if [ -z "$${CONDA_SHLVL:+x}" ]; then echo "Conda is not installed." && exit 1; fi | ||
$(CONDA_EXE) env $(shell [ -d $(env) ] && echo update || echo create) -p $(env) --file environmentwh.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this environment filename a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah.. doing a 100 thing at the same time type of typo. Thanks for the catch!
Co-authored-by: Matt Kramer <matthew.robert.kramer@gmail.com>
Co-authored-by: Matt Kramer <matthew.robert.kramer@gmail.com>
…t into fpliger/69_add_makefile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There is a suggestion to fix one of the test targets, where pytest
is missing.
.pre-commit-config.yaml
Outdated
# This is the configuration for pre-commit, a local framework for managing pre-commit hooks | ||
# Check out the docs at: https://pre-commit.com/ | ||
|
||
repos: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit
will add a newline here at the end of the file :) Not important right now.
Co-authored-by: Matt Kramer <matthew.robert.kramer@gmail.com>
Addresses #69