Skip to content

Fix #2309 - Use all config options #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

Fix #2309 - Use all config options #2310

merged 2 commits into from
Mar 10, 2025

Conversation

WebReflection
Copy link
Contributor

Description

This MR fixes #2309 by allowing py-game to pass through almost all steps regular py would, so that files, fetch, packages and others should be aligned with what py can do already.

Changes

  • updated polyscript to its latest where more utilities are explicitly exported
  • changed logic when a config file is used
  • tested that all async operations that need to be awaited are awaited and work as expected

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

@WebReflection WebReflection force-pushed the issue-2309 branch 2 times, most recently from 8416423 to 5a9ac1c Compare March 10, 2025 11:43
@WebReflection WebReflection requested a review from ntoll March 10, 2025 12:15
@WebReflection
Copy link
Contributor Author

FYI this version has been published as https://cdn.jsdelivr.net/npm/@pyscript/core@0.6.36/dist/core.js and its https://cdn.jsdelivr.net/npm/@pyscript/core@0.6.36/dist/core.css counterpart.

@ntoll today all tests failed repeatedly even on main due test_websockets.py ... I have currently removed that test and CI is green again ... should we tackle that test in another issue? I haven't changed a single line of core in here, only py-game plugin related things which are nowhere in our tests as that require manual tests (done by myself in here) ... thoughts?

@WebReflection WebReflection merged commit f2bbc6e into pyscript:main Mar 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntoll ntoll ntoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[py-game] config not resolving files
2 participants
@WebReflection @ntoll