Skip to content

Fix #2320 - Dispatch an event on code run in PyEditor #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2025
Merged

Fix #2320 - Dispatch an event on code run in PyEditor #2329

merged 3 commits into from
Apr 16, 2025

Conversation

WebReflection
Copy link
Contributor

Description

This MR would like to fix #2320 by dispatching an event from the script that is related to the PyEditor that is running the code.

Changes

  • find the related script from within the worker and dispatch a py-editor:done once the code has finished running
  • test manually that's the case and everything works as expected

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

@WebReflection WebReflection requested a review from ntoll April 8, 2025 15:23
ntoll
ntoll approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@WebReflection WebReflection merged commit 7284f7f into pyscript:main Apr 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntoll ntoll ntoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hooks not working on REPL Run button
2 participants
@WebReflection @ntoll