Added polyscript/service-worker as workaround for missing sabayon #2334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
see this live PyScript .com example
This MR tries to address @JoshuaLowe1002 comment #2333 (comment) but in a different way, because once implemented I've realized that polyfill gotta polyfill so, as opt-in, it cannot be imported or executed too late or nothing would actually work.
How to test this
First of all, the expected ServiceWorker code must be this one because the previous code used in sabayon would not work with its polyfill variant (it's outdated, I should actually deprecate everything I've done to date and just keep the polyfill as it's much better).
Secondly, there must be this
<script>
tag before pyscript on each page:That's it: if the browser needs a service-worker fallback it will bootstrap sabayon before any other code using/needing global Worker and Atomics get a chance to trap those classes.
In every other case (non Safari browsers) nothing actually happens.
Changes
@pyscript/core/service-worker
that enables back what got lost via latest updates, due bloated and slower code around it for all browsers, not just SafariChecklist
make build
works locally.