Skip to content

Fix undefined names in Python code #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2025
Merged

Fix undefined names in Python code #2371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6dc352
Fix undefined names in Python code
cclauss Aug 10, 2025
b622712
Merge branch 'main' into fix-undefined-names-in-python-code
cclauss Aug 18, 2025
ec0f54c
Merge branch 'main' into fix-undefined-names-in-python-code
WebReflection Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/tests/javascript/terminal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

classList = document.documentElement.classList

if not __terminal__:
if not __terminal__: # noqa: F821 __terminal__ is defined in core/src/plugins/donkey.js
classList.add("error")
else:
classList.add("ok")
8 changes: 2 additions & 6 deletions core/tests/manual/game/aliens.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,16 +318,12 @@ async def main(winstyle=0):
if not fullscreen:
print("Changing to FULLSCREEN")
screen_backup = screen.copy()
screen = pygame.display.set_mode(
SCREENRECT.size, winstyle | pygame.FULLSCREEN, bestdepth
)
screen = pygame.display.set_mode(SCREENRECT.size, winstyle | pygame.FULLSCREEN)
screen.blit(screen_backup, (0, 0))
else:
print("Changing to windowed mode")
screen_backup = screen.copy()
screen = pygame.display.set_mode(
SCREENRECT.size, winstyle, bestdepth
)
screen = pygame.display.set_mode(SCREENRECT.size, winstyle)
screen.blit(screen_backup, (0, 0))
pygame.display.flip()
fullscreen = not fullscreen
Expand Down
2 changes: 1 addition & 1 deletion core/tests/manual/issue-2302/libthree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def get_stats_gl(renderer):

def bg_from_v(*vertices):
geometry = new(THREE.BufferGeometry)
vertices_f32a = new(Float32Array, vertices)
vertices_f32a = new(Float32Array, vertices) # noqa: F821 Float32Array is defined in js
attr = new(THREE.Float32BufferAttribute, vertices_f32a, 3)
return geometry.setAttribute('position', attr)

Expand Down
2 changes: 1 addition & 1 deletion core/tests/python/tests/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def test_as_bytearray():
msg = b"Hello, world!"
buffer = js.ArrayBuffer.new(len(msg))
ui8a = js.Uint8Array.new(buffer)
for b in msg:
for i, b in enumerate(msg):
ui8a[i] = b
ba = util.as_bytearray(buffer)
assert isinstance(ba, bytearray)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ skip = "*.js,*.json"
[tool.ruff]
line-length = 114
lint.select = ["C4", "C90", "E", "EM", "F", "PIE", "PYI", "PLC", "Q", "RET", "W"]
lint.ignore = ["E402", "E722", "E731", "E741", "F401", "F704", "F821", "PLC0415"]
lint.ignore = ["E402", "E722", "E731", "E741", "F401", "F704", "PLC0415"]
lint.mccabe.max-complexity = 27
Loading