Skip to content

GETTING-STARTED: Dedentation is no longer required #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

GETTING-STARTED: Dedentation is no longer required #270

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented May 6, 2022 •
edited
Loading

#130 makes Python fit right into the existing HTML indentation just like JavaScript. Dedenting all the Python code looks unnatural or alien.

@cclauss
GETTING-STARTED: Dedentation is no longer required
2aa6d69 
pyscript#130 makes Python fit right into the existing HTML indentation just like JavaScript.
@mattkram
Copy link
Contributor

mattkram commented May 7, 2022

This looks good, but I don't believe the published file at https://pyscript.net/alpha/pyscript.js has been updated yet, so we should postpone this until then.

Right now, the example doesn't work against that pyscript.js file:
image

@mattkram mattkram added the status: paused PR that has been put on hold label May 7, 2022
fpliger
fpliger approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@fpliger fpliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better, thank you @cclauss ! As @mattkram suggested, we just need to wait on the cdn to have the latest changes

@fpliger fpliger added the tag: docs Related to the documentation label May 9, 2022
@fpliger fpliger mentioned this pull request May 23, 2022
Merged
@fpliger
Copy link
Contributor

fpliger commented May 23, 2022

Unfortunately, the docs infrastructure work landed before we merged this and this PR. I've opened #454 with the same fixes from here just to not ask @cclauss to do it again. Thanks for the support @cclauss !

@fpliger fpliger closed this May 23, 2022
@fpliger fpliger added status: superseded PR that has been superseded by another PR and removed status: paused PR that has been put on hold labels May 23, 2022
@cclauss cclauss deleted the patch-2 branch May 24, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpliger fpliger fpliger approved these changes

Assignees
No one assigned
Labels
status: superseded PR that has been superseded by another PR tag: docs Related to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @mattkram @fpliger