Adding textwrap.dedent for allowing indented html blocks
#275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- write indented html string - but dedent it while generating html - textwrap.dedent is meant for this purpose
for more information, see https://pre-commit.ci
A NoteThis PR is unrelated to the following: |
|
good point, they are unrelated |
for more information, see https://pre-commit.ci
|
@verhulstm I made a small indentation correction. 💡 Looks like you need to write the html block as follows to not let it look weird after linting is done. def create(self):
...
...
new_child._element.innerHTML = dedent(
f"""
<label for="flex items-center p-2 ">
<input class="mr-2" type="checkbox" class="task-check">
<p class="m-0 inline">{self.render_content()}</p>
</label>
"""
)
...
... |
fpliger
approved these changes
May 9, 2022
KOSIDOCS
pushed a commit
to KOSIDOCS/pyscript
that referenced
this pull request
May 10, 2022
) * Adding textwrap.dedent for indented html blocks - write indented html string - but dedent it while generating html - textwrap.dedent is meant for this purpose * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixed indentation * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixed indentation Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any html block, which ideally should be indented properly to enhance readability, cannot be written as is. Adding
textwrap.dedenthelps with this and allows one to write indented html blocks as strings and later properly render the html when it is generated.Example
pyscript/pyscriptjs/src/pyscript.py
Lines 254 to 265 in 22ffbcb
The update (via this PR) makes the following work.
https://github.com/sugatoray/pyscript/blob/1f076e76df426a90ed186e5d21dc0d3361c91a43/pyscriptjs/src/pyscript.py#L261-L266