Skip to content

Added prettier and eslint #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2022
Merged

Added prettier and eslint #44

merged 3 commits into from
Apr 26, 2022

Conversation

papotte
Copy link
Contributor

@papotte papotte commented Apr 25, 2022

Fix for PYS-12

  • Added eslint and prettier, as well as package.json script for running both (check and fix)
  • Fixed formatting and eslint issues
  • Added basic rules, turned all errors to warnings (should be reviewed)

@papotte papotte requested a review from princiya April 25, 2022 13:02
@princiya
Copy link
Contributor

Thank you @papotte 🎉
@fpliger what do you think? :)

fpliger
fpliger approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@fpliger fpliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you so much! 🚀

@fpliger fpliger merged commit df514fe into main Apr 26, 2022
@fpliger fpliger deleted the rb/prettier branch April 26, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpliger fpliger fpliger approved these changes

@princiya princiya princiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@papotte @princiya @fpliger