Skip to content

Bundle the Python files into the output file #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2022

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented May 22, 2022

Hi,

This PR updates Rollup config to bundle the Python files into the output file. This makes that the interpreter can load the Python logic directly.

Links:

Copy link
Contributor

@fpliger fpliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@woxtu really cool! That's an awesome improvement! Thank you!

@fpliger fpliger merged commit 3b68e1b into pyscript:main May 22, 2022
@yannickfunk
Copy link
Contributor

Does this also resolve the issue that pyscript.js is dependent on the pyscript.py when I download it from the cdn?

@woxtu woxtu deleted the bundle-python branch May 23, 2022 07:46
@woxtu
Copy link
Contributor Author

woxtu commented May 23, 2022

Yes, no need to download the Python file once this fix is released.

marianoweber pushed a commit to marianoweber/pyscript that referenced this pull request May 23, 2022
* Bundle the Python files into the output file

* Remove unused functions
marianoweber pushed a commit to marianoweber/pyscript that referenced this pull request May 23, 2022
* Bundle the Python files into the output file

* Remove unused functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants