Skip to content

Fix absolute path when import .py files in examples #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2022
Merged

Fix absolute path when import .py files in examples #88

merged 2 commits into from
May 3, 2022

Conversation

ma7dev
Copy link
Contributor

@ma7dev ma7dev commented May 1, 2022 •
edited
Loading

This PR is for this issue: #87.

fpliger
fpliger reviewed May 2, 2022
View reviewed changes
@fpliger fpliger added the tag: example Related to adding or improving examples label May 2, 2022
@philippjfr philippjfr added the status: accepted PR that has been reviewed and accepted label May 2, 2022
fpliger
fpliger approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@fpliger fpliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! Thanks @sudomaze for addressing the comments! \o/

@fpliger fpliger merged commit f04ef58 into pyscript:main May 3, 2022
@ma7dev ma7dev deleted the fix_absolute_path_examples branch May 3, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpliger fpliger fpliger approved these changes

Assignees
No one assigned
Labels
status: accepted PR that has been reviewed and accepted tag: example Related to adding or improving examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ma7dev @fpliger @philippjfr