Skip to content

add classname dynamically in examples #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2022
Merged

add classname dynamically in examples #93

merged 1 commit into from
May 2, 2022

Conversation

Mng-dev-ai
Copy link
Contributor

No description provided.

fpliger
fpliger approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@fpliger fpliger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I think we can actually remove these entirely but it's actually a good catch and improves the current code quality. Thank you for the contribution @Mng-dev-ai

@fpliger fpliger added status: accepted PR that has been reviewed and accepted tag: example Related to adding or improving examples labels May 2, 2022
@fpliger fpliger merged commit b867371 into pyscript:main May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpliger fpliger fpliger approved these changes

Assignees
No one assigned
Labels
status: accepted PR that has been reviewed and accepted tag: example Related to adding or improving examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mng-dev-ai @fpliger