Skip to content

Update PyCon.net homepage for PyCon 2024 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 10, 2024
Merged

Update PyCon.net homepage for PyCon 2024 #64

merged 7 commits into from
May 10, 2024

Conversation

ntoll
Copy link
Member

@ntoll ntoll commented May 8, 2024

First pass.

  • A real PyScript terminal.
  • Typing code.
  • Updated copy.

@ntoll
Copy link
Member Author

ntoll commented May 8, 2024

@WebReflection There is a problem with this branch.

When the "typed in" text is of a width > 50% of the terminal, Xterm.js (or something in the JS side of things) just spews out a bunch of the most recent characters. This means it doesn't work well on mobile!

Here's a video to show what I mean:

term_fail

Here's what the end result should look like:

MicroPython v1.23.0-preview.355.gbe1ecb54e on 2024-05-07; JS with Emscripten
Type "help()" for more information.
>>> print("Hello, from PyScript!")
Hello, from PyScript!
>>> # Your turn...
>>> 

Any idea how to fix this..?

@WebReflection
Copy link
Contributor

WebReflection commented May 8, 2024

edit I think I misunderstood the whole problem ... I thought it was about the terminal itself, something else is going on in here though, I will come back once I do understand what is the issue.

@ntoll
Copy link
Member Author

ntoll commented May 9, 2024

Hey hey. This is definitely a real world issue since we want folks to see PyScript working on their mobile phones, and it doesn't work properly at the moment. The repeated characters simply shouldn't be there and I'm not sure what's going on because Xterm "should" (note the air quotes) just work ™️. Perhaps a quick Zoom call will help..?

@WebReflection
Copy link
Contributor

@ntoll I've amended or removed my previous comments and I feel like I should apology I focused too much on the video and the resize behind instead of checking what is it that wasn't working as expected. We found the culprit so you are not blocked anymore but again, sorry for the rushed reply, I've been around terminals and MicroPython too much lately 😅

@ntoll
Copy link
Member Author

ntoll commented May 9, 2024

@WebReflection absolutely no problem at all. The important thing is we carefully and conscientiously worked the problem, fixed it and refined the solution. When I have the thing working to my satisfaction, I'll paste a link to the "test" version on PSDC so folks can see it in action and test in on devices. 👍

@ntoll
Copy link
Member Author

ntoll commented May 9, 2024

OK. It's ready.

Look at it in action here (thank you PSDC): https://pyscript.com/@ntoll/pyscript-net/latest

@WebReflection I have sinned - I used userAgent to sort of Firefox mobile. :-D

@ntoll ntoll marked this pull request as ready for review May 9, 2024 15:03
@ntoll
Copy link
Member Author

ntoll commented May 9, 2024

@WebReflection I fixed it. ;-)

@ntoll ntoll merged commit 3586139 into main May 10, 2024
@ntoll ntoll deleted the pycon-2024 branch May 10, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants