Add support for db fixture (test inside transaction) for asyncio tests #1223
+395
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 11, 2025 16:54
added 7 commits
August 12, 2025 10:55
kingbuzzman
reviewed
Aug 12, 2025
|
@kingbuzzman CI and myself are now happy with where the branch is at, feel free to have a deeper look now. |
|
@lode-braced can you please sync with |
Done! |
kingbuzzman
reviewed
Aug 12, 2025
tox.ini
Outdated
| @@ -10,6 +10,7 @@ envlist = | |||
| [testenv] | |||
| dependency_groups = | |||
| testing | |||
| !dj42: async | |||
There was a problem hiding this comment.
I have a bug in my CI change.... 🧐 -- this should have failed it
There was a problem hiding this comment.
Apologies, @lode-braced can you please sync with main once more.
There was a problem hiding this comment.
done
... and fixed the resulting linting issue too ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In using and debugging pytest-django with async tests & fixtures, I ended up hacking together a way to get the db fixture working by enabling the transaction in the sync to async executor thread in which async orm queries run.
This PR aims to integrate that hack as actual functionality into pytest-django.
The async work is done, I also worked to refine the sync side database access: not allowing db access to threads other than the main thread which is running the test (& transaction). That second part is causing some test failures I've yet been unable to fix on 3.9 & django 4.2, will try to fix or drop it from the PR.
edit: I managed to fix the issue with the test failures: my monkeypatches were dropping the self attribute. Ready for review.
Suggestions & feedback welcome.