Fix editorconfig check for files that don't contain python code #1226
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the editorconfig checker configuration to properly validate all project files, not just Python source directories. The issue was that the ec command was only checking specific Python source paths, missing configuration files in the project root and .github directory.
- Updated the editorconfig checker to scan the entire project directory (
.) instead of just Python source directories - Added exclusions for build artifacts and cache directories to prevent false positives
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tox.ini | Changed editorconfig checker command to scan entire project directory |
| .editorconfig-checker.json | Added exclusions for build artifacts and cache directories |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
PS. the time difference between Yet they both took 38s to finish. -- completely negligible |
Fixes small issue caused by #1225
tox.iniis not inside of paths:pytest_django,pytest_django_test,tests-- so it was never checked, as well as all the other files in the root and.github.. anyway, this is more correct.