Skip to content

Disable sort on environment table when metadata is ordered #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2018
Merged

Disable sort on environment table when metadata is ordered #162

merged 1 commit into from
May 22, 2018

Conversation

jacebrowning
Copy link
Collaborator

Closes #158

@jacebrowning jacebrowning force-pushed the preserve-environment-order branch from 26e626f to 9e21837 Compare May 3, 2018 20:02
@jacebrowning
Copy link
Collaborator Author

@davehunt Please take a look at this when you get a chance.

I've already integrated this into one of much projects like so:

def pytest_configure(config):
    metadata = OrderedDict({
        'FOO': 1,
        'BAR': 2,
    })
    setattr(config, '_metadata', metadata)
``

davehunt
davehunt approved these changes May 22, 2018
View reviewed changes
Copy link
Collaborator

@davehunt davehunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, @jacebrowning. This is awesome, thanks for including a test! I'll prepare a new release.

@davehunt davehunt merged commit fb6a456 into pytest-dev:master May 22, 2018
@jacebrowning jacebrowning deleted the preserve-environment-order branch May 26, 2018 17:58
@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davehunt davehunt davehunt approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom environment table order
3 participants
@jacebrowning @davehunt @ssbarnea