-
Notifications
You must be signed in to change notification settings - Fork 243
Fix image missing when using Base64 content #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image missing when using Base64 content #277
Conversation
@BeyondEvil could you have a look at this? Should be quite trivial. |
Thanks! I'm planning on putting in some time during the weekend to look at all open issues and PRs. |
Please rebase. Thanks. |
3af781d
to
3426bea
Compare
3426bea
to
fea4eb3
Compare
@ssbarnea I’ve rebased my branch. |
Darn it, I am the third person to create this pr [#298, after #287] with mildly different tests. @BeyondEvil - any way to review/merge this? Related to #265. [now it's cross-linked to the issue and maybe a fourth person won't write it :).] |
cc: @ssbarnea |
Sorry for not getting to this sooner @christiansandberg tl;dr had spine surgery which led to complications. Anyway, as soon as I'm satisfied with understanding the issue this is fixing (just want to see it with my own eyes) I'm going to merge this. @dhalperi Sorry you had to do all that work, but you should've checked existing issues and PRs amirite 😉 What I would like for you to do, once this is merged, is to rebase. What will be left is basically that extra test (which is awesome!) but I also want you to update All good? |
@BeyondEvil - your health takes top priority, I hope you're doing okay now. Glad to see you are able to work again. Everyone's having a different thing happening in this crazy time... I am happy to support in whatever mode is best! Let me know. (Also, if there's a gitter or slack channel that. might better facilitate realtime communication, I can go there) |
I'm jimboslice in the official SeleniumHQ slack @dhalperi :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
Again, sorry it took a while.
@BeyondEvil - the official selenium slack HQ link (from here) has expired - maybe someone there should refresh it. The question I came in to ask - will it be possible to make a new release with this fix sometime soon? |
When adding a Base64 encoded image to a non-self contained report, only an empty link is created but no image.