Enable eslint camelcase rule #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Thanks @BeyondEvil ! If you're OK with it can you merge this PR? |
|
Rerun test failed for Win I hate windows, so for me, I'm fine with adding pytest-rerunfailures and marking that test, ironically, to rerun. @gnikonorov @ssbarnea |
|
Sure, that works for me. Let me make a comment on the main discussion so we're not fragmented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables camelcase in eslint. I think this makes sense as most of the JavaScript in this repo is already camelcased, and it makes sense to have all variables follow the same convention.
I tested the changes locally and couldn't find any issues with this PR.