Skip to content

Fix: Handle appends on table hooks #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2023
Merged

Fix: Handle appends on table hooks #630

merged 1 commit into from
Apr 8, 2023

Conversation

BeyondEvil
Copy link
Contributor

@BeyondEvil BeyondEvil commented Apr 7, 2023 •
edited
Loading

Since cells was of type list in the legacy report, people might also use appends (apart from list assignment and insert) so for backwards compat, we'll add support for now.

This will be deprecated once we've decided on what the "Table" API should look like.

@BeyondEvil BeyondEvil force-pushed the beyondevil/handle-cell-append branch from 9c48b5e to ed86ca0 Compare April 7, 2023 15:15
@BeyondEvil BeyondEvil requested a review from drRedflint April 7, 2023 15:26
@BeyondEvil BeyondEvil merged commit 8350dda into pytest-dev:master Apr 8, 2023
@BeyondEvil BeyondEvil deleted the beyondevil/handle-cell-append branch April 8, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drRedflint drRedflint Awaiting requested review from drRedflint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BeyondEvil