Skip to content

Fix: results table html hook #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

BeyondEvil
Copy link
Contributor

@BeyondEvil BeyondEvil commented May 9, 2023

Not a 100% 1-to-1 with the Legacy report, but good enough.

In Legacy the data argument also contained any HTML added via extras.HTML, but since that is also under user control with even more granular control - any modifications previously done using the hook, can be done directly to the extras object instead.

Closes: #667

@BeyondEvil BeyondEvil force-pushed the beyondevil/handle-table-html branch from a045f28 to 05cf1cc Compare May 9, 2023 20:22
@BeyondEvil BeyondEvil merged commit 7992d49 into pytest-dev:master May 13, 2023
@BeyondEvil BeyondEvil deleted the beyondevil/handle-table-html branch May 13, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest_html_results_table_html hook is not passed any data
1 participant