Skip to content
This repository was archived by the owner on Nov 23, 2017. It is now read-only.

A question about run_in_executor #334

Closed
1st1 opened this issue Apr 20, 2016 · 2 comments
Closed

A question about run_in_executor #334

1st1 opened this issue Apr 20, 2016 · 2 comments

Comments

@1st1
Copy link
Member

1st1 commented Apr 20, 2016

loop.run_in_executor can accept instances of asyncio.Handle. This isn't really documented, and I consider a bit dangerous -- i.e. people can write loop.run_in_executor(loop.call_soon(cb)).

Should we deprecate this functionality?
@gvanrossum
Copy link
Member

Agreed.

1st1 added a commit that referenced this issue Oct 5, 2016
@1st1
Raise DeprecationWarning when run_in_executor is called with a Handle
99ebe37 
(Closes issue #334)
@1st1
Copy link
Member Author

1st1 commented Oct 5, 2016

Closing the issue.

@1st1 1st1 closed this as completed Oct 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@1st1 @gvanrossum