Skip to content

GitHub error #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Mariatta opened this issue Apr 6, 2019 · 0 comments · Fixed by #163
Closed

GitHub error #162

Mariatta opened this issue Apr 6, 2019 · 0 comments · Fixed by #163

Comments

@Mariatta
Copy link
Member

Mariatta commented Apr 6, 2019

I just received error alert for this. I haven't have time to investigate. Not sure if error is on our side or GitHub.

Apr 05 18:55:28 bedevere app/web.1: Traceback (most recent call last):
Apr 05 18:55:28 bedevere app/web.1: File "/app/bedevere/main.py", line 38, in main
Apr 05 18:55:28 bedevere app/web.1: await router.dispatch(event, gh)
Apr 05 18:55:28 bedevere app/web.1: File "/app/.heroku/python/lib/python3.7/site-packages/gidgethub/routing.py", line 80, in dispatch
Apr 05 18:55:28 bedevere app/web.1: await callback(event, *args, **kwargs)
Apr 05 18:55:28 bedevere app/web.1: File "/app/bedevere/bpo.py", line 51, in set_status
Apr 05 18:55:28 bedevere app/web.1: await gh.patch(event.data["pull_request"]["url"], data=body_data)
Apr 05 18:55:28 bedevere app/web.1: File "/app/.heroku/python/lib/python3.7/site-packages/gidgethub/abc.py", line 137, in patch
Apr 05 18:55:28 bedevere app/web.1: jwt=jwt, oauth_token=oauth_token)
Apr 05 18:55:28 bedevere app/web.1: File "/app/.heroku/python/lib/python3.7/site-packages/gidgethub/abc.py", line 82, in _make_request
Apr 05 18:55:28 bedevere app/web.1: data, self.rate_limit, more = sansio.decipher_response(*response)
Apr 05 18:55:28 bedevere app/web.1: File "/app/.heroku/python/lib/python3.7/site-packages/gidgethub/sansio.py", line 315, in decipher_response
Apr 05 18:55:28 bedevere app/web.1: raise InvalidField(errors, message)
Apr 05 18:55:28 bedevere app/web.1: gidgethub.InvalidField: Validation Failed for 'maintainer_can_modify'
@tirkarthi tirkarthi mentioned this issue Apr 6, 2019
Merged
@Mariatta Mariatta mentioned this issue Apr 8, 2019
Merged
Mariatta added a commit that referenced this issue Apr 8, 2019
@Mariatta
Don't pass maintainer_can_modify when patching the PR. (#163)
ebd40d7 
We used to need to pass the `maintainer_can_modify` flag, but now we're getting error message `422 Validation Failed for 'maintainer_can_modify'` when patching the PR. (to append the bpo link)

Removing the `maintainer_can_modify` flag fixes the problem, I tested in command line.
Hopefully this quick fix can unblock people.

Perhaps something changed from GitHub side, but I'm not seeing anything obvious in [their changelog](https://github.blog/changelog/).

Closes #162
Closes python/core-workflow#321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't pass maintainer_can_modify when patching the PR. Mariatta/bedevere
1 participant
@Mariatta