Skip to content

Add Pull Request Link to Issue #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Conversation

saadmk11
Copy link
Contributor

closes #501

@ghost
Copy link

ghost commented Oct 26, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #511 (dd81b76) into main (01fc118) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #511   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1878      1921   +43     
  Branches       217       222    +5     
=========================================
+ Hits          1878      1921   +43     
Flag Coverage Δ
Python_3.10 100.00% <100.00%> (ø)
Python_3.11-dev 100.00% <100.00%> (ø)
Python_3.8 100.00% <100.00%> (ø)
Python_3.9 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bedevere/gh_issue.py 100.00% <100.00%> (ø)
bedevere/util.py 100.00% <100.00%> (ø)
tests/test_gh_issue.py 100.00% <100.00%> (ø)
tests/test_util.py 100.00% <100.00%> (ø)

Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this handle issues with multiple PRs?

@saadmk11
Copy link
Contributor Author

Does this handle issues with multiple PRs?

If you mean multiple PR's pointing to the same issue, then the answer is yes. :)

@ezio-melotti ezio-melotti merged commit b76d9b2 into python:main Oct 31, 2022
@saadmk11 saadmk11 deleted the commit-on-issue branch October 31, 2022 02:55
@AlexWaygood
Copy link
Member

I really like the way this feature is working! Thanks @saadmk11!

See python/cpython#98852 for a nice example of it in action

@saadmk11
Copy link
Contributor Author

saadmk11 commented Nov 1, 2022

I really like the way this feature is working! Thanks @saadmk11!

See python/cpython#98852 for a nice example of it in action

Always happy to contribute. This was my first contribution to bedevere repository. Would be happy to contribute to some more interesting features. :)

@ezio-melotti
Copy link
Member

I really like the way this feature is working! Thanks @saadmk11!

Indeed, thanks for the PR!

There are more possible enhancement that could be added in future PRs. One would be adding the issue to the same list, instead of adding a new one-element list for each PR. Another option is to add them to a checklist or (even better) to a tasklist.
@saadmk11, would you be interested in expanding this feature? If not, I can open a separate issue as a reminder.

@saadmk11
Copy link
Contributor Author

saadmk11 commented Nov 3, 2022

I really like the way this feature is working! Thanks @saadmk11!

Indeed, thanks for the PR!

There are more possible enhancement that could be added in future PRs. One would be adding the issue to the same list, instead of adding a new one-element list for each PR. Another option is to add them to a checklist or (even better) to a tasklist.
@saadmk11, would you be interested in expanding this feature? If not, I can open a separate issue as a reminder.

Sounds interesting, can you please open an issue maybe with some examples of what you are thinking? We can discuss and implement it from there. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PR links to the issue
3 participants