Skip to content

Prepare 1.2.1 release #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Prepare 1.2.1 release #23

merged 3 commits into from
Jul 17, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 17, 2024

And move changelog to own file.

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@larryhastings
Copy link
Contributor

Have you considered using an external tool to maintain the NEWS entries, instead of maintaining it by hand?

@hugovk
Copy link
Member Author

hugovk commented Jul 17, 2024

Yes, we're actually also using GitHub's own tool to generate release notes (documented here), and they're shown on the release pages here:

In my own projects, I'm using a similar, external tool, https://github.com/release-drafter/release-drafter. I'm mainly still using this because it predates GitHub's own tool, and has some more options, and I've just not looked into switching yet.

But I think we might be okay with just the GitHub tool here. One downside is that generated changelog isn't part of the Git repo, but to be honest, I've not had any issues or requests for something to be in repo in my own projects. In one, I "retired" the changelog and pointed to the releases page instead: https://github.com/jazzband/prettytable/blob/main/CHANGELOG.md

Shall we just use GitHub's generated release notes?

@larryhastings
Copy link
Contributor

I was hinting that we could use blurb itself to maintain blurb's changelog.

@hugovk
Copy link
Member Author

hugovk commented Jul 17, 2024

That's what I thought at first, then I interpreted "external" as not blurb :)

Sure, we can do, if someone would like to volunteer to set it up. It would be a good way of testing by dogfooding.

@zooba
Copy link
Member

zooba commented Jul 17, 2024

I'm ready for this change whenever you are! (And by that I mean we're blocked from releasing 3.13.0b4 until this update happens 😉 )

@hugovk
Copy link
Member Author

hugovk commented Jul 17, 2024

Will release right away!

@hugovk hugovk merged commit 40fd999 into python:main Jul 17, 2024
13 checks passed
@hugovk hugovk deleted the prepare-release branch July 17, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants