Skip to content

blurb not compatible with Python 3.4 used on docs.iad1.psf.io #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JulienPalard opened this issue Aug 4, 2017 · 3 comments
Closed

blurb not compatible with Python 3.4 used on docs.iad1.psf.io #169

JulienPalard opened this issue Aug 4, 2017 · 3 comments
Labels
blurb

Comments

@JulienPalard
Copy link
Member

In order to run blurb while building documentations (python/docsbuild-scripts#14) we upgraded the documentation build venv from Python 2 to Python 3 (python/psf-salt#109).

The distro we're using provides Python 3.4 (python/psf-salt#109 (comment)), but blurb is not Python 3.4 compatible:

  File "blurb/blurb.py", line 1049
    subprocess.run(["git", "add", *git_add_files], stdout=subprocess.PIPE, stderr=subprocess.PIPE).check_returncode()
                                         ^
SyntaxError: can use starred expression only as assignment target
@JulienPalard JulienPalard mentioned this issue Aug 4, 2017
Closed
@Mariatta
Copy link
Member

Mariatta commented Aug 4, 2017

blurb's readme says: "blurb's only dependency is Python 3.5+."
So I'd say, please use Python 3.5+?

@Mariatta Mariatta added the blurb label Aug 4, 2017
@JulienPalard
Copy link
Member Author

@Mariatta Yes but blurb needs to run on docs.iad1.psf.io (server behind docs.python.org) which does not have Python 3.5 (python/psf-salt#109 (comment)).

As making blurb 3.4 compatible looked easy, I tried it, it may (or may not, I probably didn't test everything) solve the problem with less pain than a full server upgrade, fixing one thing at a time.

@JulienPalard
Copy link
Member Author

docs.iad1.psf.io now have Python 3.6.

Due to a bug in 3.4 (see #171 and #170) blurb will not be compatible with 3.4, let's keep the 3.5+ requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blurb
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JulienPalard @Mariatta