Skip to content

issue 169: Python 3.4 compatibility. #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

issue 169: Python 3.4 compatibility. #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e360f5
issue 169: Python 3.4 compatibility.
JulienPalard Aug 4, 2017
0108875
This run function looks unused.
JulienPalard Aug 4, 2017
4234d78
Documenting the Python 3.4 compatibility in readme and flit.ini.
JulienPalard Aug 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion blurb/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ and automatically uses the correct file paths.

You can install **blurb** from PyPI using ``pip``. Alternatively,
simply add ``blurb`` to a directory on your path.
**blurb**'s only dependency is Python 3.5+.
**blurb**'s only dependency is Python 3.4+.


Files used by blurb
Expand Down
18 changes: 5 additions & 13 deletions blurb/blurb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,13 +638,6 @@ def filename_test(self, filename):
b.read(filename)



def run(s):
process = subprocess.run(s.split(), stdout=subprocess.PIPE, stderr=subprocess.PIPE)
process.check_returncode()
return process.stdout.decode('ascii')


readme_re = re.compile(r"This is Python version [23]\.\d").match

def chdir_to_repo_root():
Expand Down Expand Up @@ -858,7 +851,7 @@ def init_tmp_with_template():
init_tmp_with_template()

while True:
subprocess.run([editor, tmp_path])
subprocess.call([editor, tmp_path])

failure = None
blurb = Blurbs()
Expand Down Expand Up @@ -1046,16 +1039,15 @@ def print(*a, sep=" "):
git_add_files = []
def flush_git_add_files():
if git_add_files:
subprocess.run(["git", "add", *git_add_files], stdout=subprocess.PIPE, stderr=subprocess.PIPE).check_returncode()
subprocess.check_call(["git", "add"] + git_add_files,
stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
git_add_files.clear()

git_rm_files = []
def flush_git_rm_files():
if git_rm_files:
try:
subprocess.run(["git", "rm", "-f", *git_rm_files], stdout=subprocess.PIPE, stderr=subprocess.PIPE).check_returncode()
except subprocess.CalledProcessError:
pass
subprocess.call(["git", "rm", "-f"] + git_rm_files,
stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)

# clean up
for path in git_rm_files:
Expand Down
2 changes: 1 addition & 1 deletion blurb/flit.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ author-email = larry@hastings.org
maintainer = Python Core Developers
maintainer-email = core-workflow@mail.python.org
home-page = https://github.com/python/core-workflow/tree/master/blurb
requires-python = >=3.5
requires-python = >=3.4
description-file = README.rst
classifiers = Intended Audience :: Developers
License :: OSI Approved :: BSD License
Expand Down