Manage fixing commit message by config file setting #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mariatta
requested changes
Apr 7, 2018
| @@ -20,7 +20,8 @@ | |||
| DEFAULT_CONFIG = collections.ChainMap({ | |||
| 'team': 'python', | |||
| 'repo': 'cpython', | |||
| 'check_sha': '7f777ed95a19224294949e1b4ce56bbffcb1fe9f'}) | |||
| 'check_sha': '7f777ed95a19224294949e1b4ce56bbffcb1fe9f', | |||
| 'fix_commit_msg': True}) | |||
There was a problem hiding this comment.
Nitpicky, can this be:
'fix_commit_msg': True,
})
| @@ -175,7 +179,7 @@ def amend_commit_message(self, cherry_pick_branch): | |||
|
|
|||
|
|
|||
| Co-authored-by: {get_author_info_from_short_sha(self.commit_sha1)}""" | |||
| updated_commit_message = updated_commit_message.replace('#', 'GH-') | |||
| # updated_commit_message = updated_commit_message.replace('#', 'GH-') | |||
cherry_picker/readme.rst
Outdated
| Roundup bug tracker (https://bugs.python.org) behavior: | ||
| #xxxx should point on issue xxxx but GH-xxxx points | ||
| on pull-request xxxx. | ||
| For projects with builtin GitHub bug tracker |
There was a problem hiding this comment.
Perhaps rephrase a little bit:
"For projects using GitHub Issues, this option can be disabled."
Just wanted to make this an option/choice, whereas "should" can mean "you must change this value".
|
Fixed |
Mariatta
approved these changes
Apr 8, 2018
|
Thanks! |
Mariatta
pushed a commit
that referenced
this pull request
Apr 8, 2018
Setting fix_commit_msg to True will replace the issue number in the commit message, from `#` to `GH-`.
|
Thanks @asvetlov 😄 Published to PyPI! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed before
#->GH-replacement should be default behavior as required by CPython but we need a way to disable this replacement by config file settings.