cherry-picker: Run Travis CI test on Windows #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Feb 22, 2019
webknjaz
reviewed
Feb 22, 2019
|
It should be easy to fix tests by extending this fixture (https://github.com/python/core-workflow/blob/b3c68fe/cherry_picker/cherry_picker/test.py#L87-L91) to set local user and email in config. |
|
Oh, one more thing I meant to put in the initial comment: Unfortunately I probably won't find much time to tend to this PR properly. Feel free to make changes directly to the branch, that'll make things much faster. |
|
Another thing is that Travis CI seems to be going down now: ansible/molecule#1770 |
webknjaz
reviewed
Mar 15, 2019
|
Git config related tests fixed. Now, there's two Unicode-related failures. |
|
@Mariatta please merge it, it's ready. |
Mariatta
approved these changes
Mar 16, 2019
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've set up a Windows build on Travis before, maybe I can help #296 a bit!
There's no Python pre-installed, but there's a package manager,
choco, that can install it.Currently, the tests fail because they seem to require Git's
user.emailanduser.nameto be set globally. They fail on my dev machine as well, since I don't have an e-mail set globally (I use different e-mail addresses on different repos).Sadly, I can't devote time to fixing that issue, but I can help to reproduce or explain more if needed.
To try out changes privately, here's what I do: