[3.13] gh-121660: Fix ga_getitem by explicitly checking for NULL result (GH-121661) (#121761)

miss-islington · sobolevn · web-flow · commit 97b06d543fed · 2024-07-14T11:48:33.000Z
gh-121660: Fix `ga_getitem` by explicitly checking for `NULL` result (GH-121661) (cherry picked from commit bb802db) Co-authored-by: sobolevn <mail@sobolevn.me>
diff --git a/Objects/genericaliasobject.c b/Objects/genericaliasobject.c
@@ -561,6 +561,10 @@ ga_getitem(PyObject *self, PyObject *item)
     }
 
     PyObject *res = Py_GenericAlias(alias->origin, newargs);
+    if (res == NULL) {
+        Py_DECREF(newargs);
+        return NULL;
+    }
     ((gaobject *)res)->starred = alias->starred;
 
     Py_DECREF(newargs);

Original file line number	Diff line number	Diff line change
`@@ -561,6 +561,10 @@ ga_getitem(PyObject self, PyObject item)`
`561`	`561`	`}`
`562`	`562`
`563`	`563`	`PyObject *res = Py_GenericAlias(alias->origin, newargs);`
	`564`	`+ if (res == NULL) {`
	`565`	`+ Py_DECREF(newargs);`
	`566`	`+ return NULL;`
	`567`	`+ }`
`564`	`568`	`((gaobject *)res)->starred = alias->starred;`
`565`	`569`
`566`	`570`	`Py_DECREF(newargs);`