Skip to content

gh-121660: Fix ga_getitem by explicitly checking for NULL result #121661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2024
Merged

gh-121660: Fix ga_getitem by explicitly checking for NULL result #121661

merged 1 commit into from
Jul 14, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 13, 2024 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn requested a review from JelleZijlstra July 13, 2024 08:20
@bedevere-app bedevere-app bot mentioned this pull request Jul 13, 2024
Closed
@Eclips4 Eclips4 added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 13, 2024
JelleZijlstra
JelleZijlstra approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It appears this can only happen if there is a memory failure (e.g., PyTuple_Pack fails), so it's not feasible to test for it, but we should still fix this.

IljaManakov added a commit to IljaManakov/cpython that referenced this pull request Jul 14, 2024
@IljaManakov
pythongh-121661: Comments from Łukasz
ecc2127
IljaManakov added a commit to IljaManakov/cpython that referenced this pull request Jul 14, 2024
@IljaManakov
pythongh-121661: Fix error in exception handling
f3aa6f6
IljaManakov added a commit to IljaManakov/cpython that referenced this pull request Jul 14, 2024
@IljaManakov
pythongh-121661: Add test
35ffc98
@sobolevn sobolevn merged commit bb802db into python:main Jul 14, 2024
40 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 14, 2024
@sobolevn @miss-islington
pythongh-121660: Fix ga_getitem by explicitly checking for NULL r…
a090434 
…esult (pythonGH-121661)

(cherry picked from commit bb802db)

Co-authored-by: sobolevn <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 14, 2024
@sobolevn @miss-islington
pythongh-121660: Fix ga_getitem by explicitly checking for NULL r…
599f2f2 
…esult (pythonGH-121661)

(cherry picked from commit bb802db)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Jul 14, 2024

GH-121761 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 14, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 14, 2024

GH-121762 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jul 14, 2024
sobolevn added a commit that referenced this pull request Jul 14, 2024
@miss-islington @sobolevn
[3.12] gh-121660: Fix ga_getitem by explicitly checking for NULL …
7a4b55d 
…result (GH-121661) (#121762)

gh-121660: Fix `ga_getitem` by explicitly checking for `NULL` result (GH-121661)
(cherry picked from commit bb802db)

Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Jul 14, 2024
@miss-islington @sobolevn
[3.13] gh-121660: Fix ga_getitem by explicitly checking for NULL …
97b06d5 
…result (GH-121661) (#121761)

gh-121660: Fix `ga_getitem` by explicitly checking for `NULL` result (GH-121661)
(cherry picked from commit bb802db)

Co-authored-by: sobolevn <mail@sobolevn.me>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @estyxx
pythongh-121660: Fix ga_getitem by explicitly checking for NULL r…
41baa8d 
…esult (python#121661)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @JelleZijlstra @Eclips4