[3.13] gh-117657: Fix missing atomic in dict_resize (GH-119312) (#119417)

miss-islington · DinoV · web-flow · commit cd35e9d85a89 · 2024-05-22T14:42:47.000-07:00
gh-117657: Fix missing atomic in dict_resize (GH-119312) Fix missing atomic in dict_resize (cherry picked from commit 2b3fb76) Co-authored-by: Dino Viehland <dinoviehland@meta.com>
diff --git a/Objects/dictobject.c b/Objects/dictobject.c
@@ -2003,7 +2003,7 @@ dictresize(PyInterpreterState *interp, PyDictObject *mp,
         if (oldvalues->embedded) {
             assert(oldvalues->embedded == 1);
             assert(oldvalues->valid == 1);
-            oldvalues->valid = 0;
+            FT_ATOMIC_STORE_UINT8(oldvalues->valid, 0);
         }
         else {
             free_values(oldvalues, IS_DICT_SHARED(mp));

Original file line number	Diff line number	Diff line change
`@@ -2003,7 +2003,7 @@ dictresize(PyInterpreterState interp, PyDictObject mp,`
`2003`	`2003`	`if (oldvalues->embedded) {`
`2004`	`2004`	`assert(oldvalues->embedded == 1);`
`2005`	`2005`	`assert(oldvalues->valid == 1);`
`2006`		`- oldvalues->valid = 0;`
	`2006`	`+ FT_ATOMIC_STORE_UINT8(oldvalues->valid, 0);`
`2007`	`2007`	`}`
`2008`	`2008`	`else {`
`2009`	`2009`	`free_values(oldvalues, IS_DICT_SHARED(mp));`