gh-129539: Include sysexits.h before checking EX_OK

collinfunk · collinfunk · commit ef40eeae8df3 · 2025-02-01T10:57:38.000-08:00
Previously the macro would be redefined when the header was included.
diff --git a/Misc/NEWS.d/next/Build/2025-01-31-19-01-24.gh-issue-129539.6ndioH.rst b/Misc/NEWS.d/next/Build/2025-01-31-19-01-24.gh-issue-129539.6ndioH.rst
@@ -0,0 +1 @@
+Don't redefine ``EX_OK`` when the system has the ``sysexits.h`` header.
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
@@ -52,10 +52,6 @@
 #  include "winreparse.h"
 #endif
 
-#if !defined(EX_OK) && defined(EXIT_SUCCESS)
-#  define EX_OK EXIT_SUCCESS
-#endif
-
 #ifdef __APPLE__
  /* Needed for the implementation of os.statvfs */
 #  include <sys/param.h>
@@ -295,6 +291,10 @@ corresponding Unix manual entries for more information on calls.");
 #  include <sysexits.h>
 #endif
 
+#if !defined(EX_OK) && defined(EXIT_SUCCESS)
+#  define EX_OK EXIT_SUCCESS
+#endif
+
 #ifdef HAVE_SYS_LOADAVG_H
 #  include <sys/loadavg.h>
 #endif

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Don't redefine ``EX_OK`` when the system has the ``sysexits.h`` header.