gh-118974: Add dataclass_factory argument to make_dataclass

Viicos · Viicos · commit f565a4a949d2 · 2024-08-06T09:03:59.000+02:00
diff --git a/Lib/dataclasses.py b/Lib/dataclasses.py
@@ -1492,7 +1492,7 @@ def _astuple_inner(obj, tuple_factory):
 def make_dataclass(cls_name, fields, *, bases=(), namespace=None, init=True,
                    repr=True, eq=True, order=False, unsafe_hash=False,
                    frozen=False, match_args=True, kw_only=False, slots=False,
-                   weakref_slot=False, module=None):
+                   weakref_slot=False, module=None, dataclass_factory=dataclass):
     """Return a new dynamically created dataclass.
 
     The dataclass name will be 'cls_name'.  'fields' is an iterable
@@ -1572,11 +1572,11 @@ def exec_body_callback(ns):
     if module is not None:
         cls.__module__ = module
 
-    # Apply the normal decorator.
-    return dataclass(cls, init=init, repr=repr, eq=eq, order=order,
-                     unsafe_hash=unsafe_hash, frozen=frozen,
-                     match_args=match_args, kw_only=kw_only, slots=slots,
-                     weakref_slot=weakref_slot)
+    # Apply the normal provided decorator.
+    return dataclass_factory(cls, init=init, repr=repr, eq=eq, order=order,
+                             unsafe_hash=unsafe_hash, frozen=frozen,
+                             match_args=match_args, kw_only=kw_only, slots=slots,
+                             weakref_slot=weakref_slot)
 
 
 def replace(obj, /, **changes):
diff --git a/Lib/test/test_dataclasses/__init__.py b/Lib/test/test_dataclasses/__init__.py
@@ -4204,6 +4204,26 @@ def test_funny_class_names_names(self):
                 C = make_dataclass(classname, ['a', 'b'])
                 self.assertEqual(C.__name__, classname)
 
+    def test_dataclass_factory_default(self):
+        C = make_dataclass('C', [('x', int)], dataclass_factory=dataclass)
+        c = C(10)
+        self.assertEqual(c.x, 10)
+
+    def test_dataclass_custom_factory(self):
+        def custom_dataclass(cls, *args, **kwargs):
+            def wrap(cls):
+                dc = dataclass(cls, *args, **kwargs)
+                dc.__custom__ = True
+                return dc
+
+            return wrap(cls)
+
+        C = make_dataclass('C', [('x', int)], dataclass_factory=custom_dataclass)
+        c = C(10)
+        self.assertEqual(c.x, 10)
+        self.assertEqual(c.__custom__, True)
+
+
 class TestReplace(unittest.TestCase):
     def test(self):
         @dataclass(frozen=True)
