Skip to content

Build failure on wasm-sdk-17 #100340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kushaldas opened this issue Dec 19, 2022 · 0 comments
Closed

Build failure on wasm-sdk-17 #100340

kushaldas opened this issue Dec 19, 2022 · 0 comments
Labels
build The build process and cross-build OS-wasi type-bug An unexpected behavior, bug, or error

Comments

@kushaldas
Copy link
Member

kushaldas commented Dec 19, 2022

Bug report

wasi build is failing on the latest wasm-sdk-17 due to a change in clang itself.

How to verify the failure?

Install latest (version 17) of the wasm-sdk from the link above.

Then:

./Tools/wasm/wasm_build.py wasi

...
<snipped output>

ccache /opt/wasi-sdk/bin/clang  -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall    -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Werror=implicit-function-declaration -fvisibility=hidden  -I../../Include/internal -IObjects -IInclude -IPython -I. -I../../Include    -DPy_BUILD_CORE_BUILTIN -c ../../Modules/_weakref.c -o Modules/_weakref.o
../../Modules/timemodule.c:1972:13: error: incompatible pointer to integer conversion passing 'const struct __clockid *' to parameter of type 'long' [-Wint-conversion]
        if (PyModule_AddIntMacro(module, CLOCK_REALTIME) < 0) {
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../Include/modsupport.h:59:69: note: expanded from macro 'PyModule_AddIntMacro'
#define PyModule_AddIntMacro(m, c) PyModule_AddIntConstant((m), #c, (c))
                                                                    ^~~
../../Include/modsupport.h:51:71: note: passing argument to parameter here
PyAPI_FUNC(int) PyModule_AddIntConstant(PyObject *, const char *, long);
                                                                      ^
../../Modules/timemodule.c:1979:13: error: incompatible pointer to integer conversion passing 'const struct __clockid *' to parameter of type 'long' [-Wint-conversion]
        if (PyModule_AddIntMacro(module, CLOCK_MONOTONIC) < 0) {
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../Include/modsupport.h:59:69: note: expanded from macro 'PyModule_AddIntMacro'
#define PyModule_AddIntMacro(m, c) PyModule_AddIntConstant((m), #c, (c))
                                                                    ^~~
../../Include/modsupport.h:51:71: note: passing argument to parameter here
PyAPI_FUNC(int) PyModule_AddIntConstant(PyObject *, const char *, long);
                                                                      ^
2 errors generated.
make: *** [Makefile:2872: Modules/timemodule.o] Error 1
make: *** Waiting for unfinished jobs....

Linked PRs

@kushaldas kushaldas added the type-bug An unexpected behavior, bug, or error label Dec 19, 2022
kushaldas added a commit to kushaldas/cpython that referenced this issue Dec 19, 2022
kushaldas added a commit to kushaldas/cpython that referenced this issue Dec 19, 2022
@AlexWaygood AlexWaygood added build The build process and cross-build OS-wasi labels Dec 19, 2022
kushaldas added a commit to kushaldas/cpython that referenced this issue Dec 20, 2022
kushaldas added a commit to kushaldas/cpython that referenced this issue Dec 20, 2022
kushaldas added a commit to kushaldas/cpython that referenced this issue Jan 17, 2023
@brettcannon brettcannon moved this from Todo to Done in WASI to tier 2 Jun 3, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 24, 2023
Fixes pythonGH-100340 allows -Wno-int-conversion for wasm
(cherry picked from commit 75c8133)

Co-authored-by: Kushal Das <mail@kushaldas.in>
erlend-aasland pushed a commit that referenced this issue Jun 28, 2023
…06066)

(cherry picked from commit 75c8133)

Co-authored-by: Kushal Das <mail@kushaldas.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build OS-wasi type-bug An unexpected behavior, bug, or error
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants