Skip to content

AIX build with XLC compiler fails with main branch #102204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ayappanec opened this issue Feb 24, 2023 · 1 comment
Closed

AIX build with XLC compiler fails with main branch #102204

ayappanec opened this issue Feb 24, 2023 · 1 comment
Assignees
@gpshead
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@ayappanec
Copy link
Contributor

ayappanec commented Feb 24, 2023 •
edited by bedevere-bot
Loading

xlc_r -c -I./Modules/expat -DNDEBUG -O -qalias=noansi -qmaxmem=-1 -I./Include/internal -I. -I./Include -o Modules/expat/xmlrole.o ./Modules/expat/xmlrole.c
"./Modules/_hacl/include/krml/lowstar_endianness.h", line 152.4: 1506-205 (S) #error "Please define __BYTE_ORDER__!"
xlc_r -c -I./Modules/expat -DNDEBUG -O -qalias=noansi -qmaxmem=-1 -I./Include/internal -I. -I./Include -o Modules/expat/xmltok.o ./Modules/expat/xmltok.c

AIX doesn't have endian.h file. With XLC compiler __BYTE_ORDER__ is also not available.
AIX is always big-endian. So probably "defined(_AIX)" is needed in the generic big-endian fallback code in lowstar_endianness.h.

Linked PRs
@ayappanec ayappanec added the type-bug An unexpected behavior, bug, or error label Feb 24, 2023
@AlexWaygood AlexWaygood added the build The build process and cross-build label Feb 24, 2023
ayappanec added a commit to ayappanec/cpython that referenced this issue Feb 24, 2023
@ayappanec
pythongh-102204: Fix endianness issue in AIX
d5b132a
@ayappanec ayappanec mentioned this issue Feb 24, 2023
Closed
ayappanec added a commit to ayappanec/cpython that referenced this issue Feb 27, 2023
@ayappanec
Merge branch 'main' into pythongh-102204
43871c1
ayappanec added a commit to ayappanec/cpython that referenced this issue Mar 7, 2023
@ayappanec
Merge branch 'main' into pythongh-102204
388d77b
@gpshead gpshead self-assigned this Apr 2, 2023
@ayappanec
Copy link
Contributor Author

This is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gpshead gpshead

Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gpshead @ayappanec @AlexWaygood