Skip to content

Add #line directives to generated_cases.c.h #102654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gvanrossum opened this issue Mar 13, 2023 · 0 comments
Closed

Add #line directives to generated_cases.c.h #102654

gvanrossum opened this issue Mar 13, 2023 · 0 comments
Assignees
@gvanrossum
Labels
type-bug An unexpected behavior, bug, or error

Comments

@gvanrossum
Copy link
Member

gvanrossum commented Mar 13, 2023 •
edited by bedevere-bot
Loading

It would be nice if compiler errors in Python/bytecodes.c actually pointed to the file you have to edit.

(Filing for @markshannon.)

Linked PRs
@gvanrossum gvanrossum added the type-bug An unexpected behavior, bug, or error label Mar 13, 2023
@gvanrossum gvanrossum self-assigned this Mar 13, 2023
@bedevere-bot bedevere-bot mentioned this issue Mar 13, 2023
Merged
gvanrossum added a commit that referenced this issue Mar 15, 2023
@gvanrossum
gh-102654: Insert #line directives in generated_cases.c.h (#102669)
70185de 
This behavior is optional, because in some extreme cases it
may just make debugging harder. The tool defaults it to off,
but it is on in Makefile.pre.in.

Also note that this makes diffs to generated_cases.c.h noisier,
since whenever you insert or delete a line in bytecodes.c,
all subsequent #line directives will change.
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@gvanrossum @Fidget-Spinner
pythongh-102654: Insert #line directives in generated_cases.c.h (pyth…
71190ac 
…on#102669)

This behavior is optional, because in some extreme cases it
may just make debugging harder. The tool defaults it to off,
but it is on in Makefile.pre.in.

Also note that this makes diffs to generated_cases.c.h noisier,
since whenever you insert or delete a line in bytecodes.c,
all subsequent #line directives will change.
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@gvanrossum @warsaw
pythongh-102654: Insert #line directives in generated_cases.c.h (pyth…
cddb24b 
…on#102669)

This behavior is optional, because in some extreme cases it
may just make debugging harder. The tool defaults it to off,
but it is on in Makefile.pre.in.

Also note that this makes diffs to generated_cases.c.h noisier,
since whenever you insert or delete a line in bytecodes.c,
all subsequent #line directives will change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gvanrossum gvanrossum

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gvanrossum and others