Skip to content

Remove unittest's deprecated getTestCaseNames, makeSuite, findTestCases #104835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hugovk opened this issue May 24, 2023 · 0 comments · Fixed by #104836
Closed

Remove unittest's deprecated getTestCaseNames, makeSuite, findTestCases #104835

hugovk opened this issue May 24, 2023 · 0 comments · Fixed by #104836
Labels
3.13 bugs and security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@hugovk
Copy link
Member

hugovk commented May 24, 2023 •
edited by bedevere-bot
Loading

Feature or enhancement

Prior to Python 3.11, unittest's getTestCaseNames, makeSuite and findTestCases were commented:

these functions should be considered obsolete

They were deprecated with warnings in 3.11 and scheduled for removal in 3.13.

Previous discussion

Linked PRs
@hugovk hugovk added the type-feature A feature request or enhancement label May 24, 2023
@sunmy2019 sunmy2019 added 3.13 bugs and security fixes stdlib Python modules in the Lib dir labels May 24, 2023
@hugovk hugovk changed the title Removed unittest's deprecated getTestCaseNames, makeSuite, findTestCases Remove unittest's deprecated getTestCaseNames, makeSuite, findTestCases May 24, 2023
@bedevere-bot bedevere-bot mentioned this issue May 24, 2023
Merged
hugovk added a commit that referenced this issue May 24, 2023
@hugovk
gh-104835: Remove unittest's deprecated getTestCaseNames, makeSuite, …
b1cb30e 
…findTestCases (#104836)
markmentovai added a commit to markmentovai/pyftdi that referenced this issue Nov 4, 2024
@markmentovai
tests: Fix for Python 3.13 (unittest.makeSuite was removed)
426e1ab 
```
ImportError while importing test module '…/pyftdi/pyftdi/tests/toolsimport.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
…/lib/python3.13/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
pyftdi/tests/toolsimport.py:16: in <module>
    from unittest import TestCase, TestSuite, makeSuite, main as ut_main
E   ImportError: cannot import name 'makeSuite' from 'unittest' (…/lib/python3.13/unittest/__init__.py)
```

python/cpython#104835
python/cpython#104836
python/cpython@b1cb30e
https://docs.python.org/3/whatsnew/3.13.html#unittest
@markmentovai markmentovai mentioned this issue Nov 4, 2024
Merged
eblot pushed a commit to eblot/pyftdi that referenced this issue Nov 19, 2024
@markmentovai @eblot
tests: Fix for Python 3.13 (unittest.makeSuite was removed)
0017c01 
```
ImportError while importing test module '…/pyftdi/pyftdi/tests/toolsimport.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
…/lib/python3.13/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
pyftdi/tests/toolsimport.py:16: in <module>
    from unittest import TestCase, TestSuite, makeSuite, main as ut_main
E   ImportError: cannot import name 'makeSuite' from 'unittest' (…/lib/python3.13/unittest/__init__.py)
```

python/cpython#104835
python/cpython#104836
python/cpython@b1cb30e
https://docs.python.org/3/whatsnew/3.13.html#unittest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-104835: Remove unittest's deprecated getTestCaseNames, makeSuite, findTestCases hugovk/cpython
2 participants
@hugovk @sunmy2019