Skip to content

test_logging: test_post_fork_child_no_deadlock() failed on Address sanitizer #110656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vstinner opened this issue Oct 10, 2023 · 0 comments
Closed

test_logging: test_post_fork_child_no_deadlock() failed on Address sanitizer #110656

vstinner opened this issue Oct 10, 2023 · 0 comments
Labels
tests Tests in the Lib/test dir

Comments

@vstinner
Copy link
Member

vstinner commented Oct 10, 2023 •
edited by bedevere-app bot
Loading

That's another victim of libasan deadlock involving fork. See test_threading:

# gh-89363: Skip fork() test if Python is built with Address Sanitizer (ASAN)
# to work around a libasan race condition, dead lock in pthread_create().
skip_if_asan_fork = support.skip_if_sanitizer(
                        "libasan has a pthread_create() dead lock",
                        address=True)

Address sanitizer:

FAIL: test_post_fork_child_no_deadlock (test.test_logging.HandlerTest.test_post_fork_child_no_deadlock)
Ensure child logging locks are not held; bpo-6721 & bpo-36533.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_logging.py", line 789, in test_post_fork_child_no_deadlock
    support.wait_process(pid, exitcode=0)
  File "/home/runner/work/cpython/cpython/Lib/test/support/__init__.py", line 2206, in wait_process
    raise AssertionError(f"process {pid} is still running "
AssertionError: process 12448 is still running after 300.4 seconds

build: https://github.com/python/cpython/actions/runs/6475004361/job/17581154367?pr=110650

Linked PRs
@vstinner vstinner added the tests Tests in the Lib/test dir label Oct 10, 2023
@vstinner vstinner mentioned this issue Oct 10, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Oct 10, 2023
@vstinner
pythongh-110656: Fix logging test_post_fork_child_no_deadlock() if ASAN
17cd145 
Add support.HAVE_ASAN_FORK_BUG.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 10, 2023
@vstinner
pythongh-110656: Fix logging test_post_fork_child_no_deadlock() if ASAN
f6213ad 
Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.
@bedevere-app bedevere-app bot mentioned this issue Oct 10, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Oct 10, 2023
@vstinner
pythongh-110656: Fix logging test_post_fork_child_no_deadlock() if ASAN
0998c51 
Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 11, 2023
@vstinner
pythongh-110656: Fix logging test_post_fork_child_no_deadlock() if ASAN
054ec0a 
Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.
vstinner added a commit that referenced this issue Oct 11, 2023
@vstinner
gh-110656: Fix logging test_post_fork_child_no_deadlock() if ASAN (#1…
f901f56 
…10657)

Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 11, 2023
@vstinner @miss-islington
pythongh-110656: Fix logging test_post_fork_child_no_deadlock() if AS…
bd3b74a 
…AN (pythonGH-110657)

Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.
(cherry picked from commit f901f56)

Co-authored-by: Victor Stinner <vstinner@python.org>
This was referenced Oct 11, 2023
Merged
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 11, 2023
@vstinner @miss-islington
pythongh-110656: Fix logging test_post_fork_child_no_deadlock() if AS…
e82636b 
…AN (pythonGH-110657)

Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.
(cherry picked from commit f901f56)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this issue Oct 11, 2023
@miss-islington @vstinner
[3.11] gh-110656: Fix logging test_post_fork_child_no_deadlock() if A…
7984dc2 
…SAN (GH-110657) (#110665)

gh-110656: Fix logging test_post_fork_child_no_deadlock() if ASAN (GH-110657)

Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.
(cherry picked from commit f901f56)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this issue Oct 11, 2023
@miss-islington @vstinner
[3.12] gh-110656: Fix logging test_post_fork_child_no_deadlock() if A…
55448a5 
…SAN (GH-110657) (#110664)

gh-110656: Fix logging test_post_fork_child_no_deadlock() if ASAN (GH-110657)

Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.
(cherry picked from commit f901f56)

Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@vstinner @Glyphack
pythongh-110656: Fix logging test_post_fork_child_no_deadlock() if AS…
8283a34 
…AN (python#110657)

Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vstinner