Add more C API tests #111495

serhiy-storchaka · 2023-10-30T14:50:58Z

skirpichev · 2023-10-31T08:59:01Z

@serhiy-storchaka, initial set of C API tests for PyComplex (only for changed functions) was added in #109647

serhiy-storchaka · 2023-10-31T10:06:02Z

Yes, there are also some tests for PyLong and PyNumber, and maybe other parts of the C API. But we should test the full C API, or at least document what is not tested. And it is better to group tests by the prefix, so it is clear where to find tests.

serhiy-storchaka · 2023-10-31T10:12:27Z

If you want to work on adding tests to the part of the C API, say it here to avoid duplicating the work of other people. I finished work on PyBytes and PyByteArray and am not currently working on any of the above.

skirpichev · 2023-10-31T12:08:32Z

@serhiy-storchaka, I will factor out tests PyComplex_RealAsDouble/ImagAsDouble from #109647 and tests for other functions for PyComplexType. (BTW, in #111496 I don't see actual tests, only interfaces. Tests in my pr were modeled from pack/unpack tests in test_float.py.)

serhiy-storchaka · 2023-10-31T12:30:10Z

Good catch, @skirpichev. I forgot to add the actual test files.

rawwar · 2023-10-31T12:56:50Z

@serhiy-storchaka , I would like to contribute tests to PyTuple and PyList C API

serhiy-storchaka · 2023-10-31T13:35:01Z

@serhiy-storchaka , I would like to contribute tests to PyTuple and PyList C API

Great. Look at existing PySequence tests in Lib/test/test_capi/test_abstract.py. Some PyTuple and PyList tests can be a copy of PySequence tests. Look also at PyDict and PySet tests.

skirpichev · 2023-11-01T00:55:33Z

With multiple prs, Modules/Setup.stdlib.in will produce merge conflicts. (I already have fixed this a lot in #109647.) I will create a pr to add stub files for testing modules.

Edit:
#111586 - stub files for test modules
#111591 - tests for PyComplex C API on top of #111586

Then I'll add missing tests for PyFloat's C API.

This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue.

serhiy-storchaka · 2023-11-01T05:34:35Z

I will create a pr to add stub files for testing modules.

Good idea!

This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue.

…GH-111586) This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue. (cherry picked from commit 33ed5fa) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>

…H-111592) This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue. (cherry picked from commit 33ed5fa)

sobolevn · 2023-11-01T14:30:03Z

I am working on PyFile_ tests.

Signed-off-by: kalyanr <kalyan.ben10@live.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>

(cherry picked from commit dbc1752) Co-authored-by: kalyanr <kalyan.ben10@live.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>

(cherry picked from commit 2f20f5a)

For now, skip some crashers (tracked in gh-123378).

For now, skip some crashers (tracked in pythongh-123378).

* Add Lib/test/test_capi/test_eval.py * Add Modules/_testlimitedcapi/eval.c (cherry picked from commit bf8b374)

…2851) (cherry picked from commit b4a3160)

* gh-111495: Add more tests on PyEval C APIs (#122789) * Add Lib/test/test_capi/test_eval.py * Add Modules/_testlimitedcapi/eval.c (cherry picked from commit bf8b374) * gh-111495: Fix refleaks in test_capi.test_eval tests (#122851) (cherry picked from commit b4a3160)

…#129023) * Add Lib/test/test_capi/test_eval.py * Add Modules/_testlimitedcapi/eval.c (cherry picked from commit bf8b374) * gh-111495: Fix refleaks in test_capi.test_eval tests (#122851) (cherry picked from commit b4a3160) (cherry picked from commit 430ccbc)

Add tests for the following functions in test_capi.test_file: * PyFile_FromFd() * PyFile_GetLine() * PyFile_NewStdPrinter() * PyFile_WriteObject() * PyFile_WriteString() * PyObject_AsFileDescriptor() Add Modules/_testlimitedcapi/file.c file. Remove now redundant test_embed.StdPrinterTests.

Add tests for the following functions in test_capi.test_file: * PyFile_FromFd() * PyFile_GetLine() * PyFile_NewStdPrinter() * PyFile_WriteObject() * PyFile_WriteString() * PyObject_AsFileDescriptor() Add Modules/_testlimitedcapi/file.c file. Remove test_embed.StdPrinterTests which became redundant.

Add tests for the following functions in test_capi.test_file: * PyFile_FromFd() * PyFile_GetLine() * PyFile_NewStdPrinter() * PyFile_WriteObject() * PyFile_WriteString() * PyObject_AsFileDescriptor() Add Modules/_testlimitedcapi/file.c file. Remove test_embed.StdPrinterTests which became redundant. (cherry picked from commit 4ca9fc0)

vstinner · 2025-01-30T17:13:50Z

@serhiy-storchaka: I added tests on the PyFile C API with #129449. It was the last checkbox. Can we close this issue now?

gh-111495: Add PyFile tests (#129449) Add tests for the following functions in test_capi.test_file: * PyFile_FromFd() * PyFile_GetLine() * PyFile_NewStdPrinter() * PyFile_WriteObject() * PyFile_WriteString() * PyObject_AsFileDescriptor() Add Modules/_testlimitedcapi/file.c file. Remove test_embed.StdPrinterTests which became redundant. (cherry picked from commit 4ca9fc0)

[3.13] gh-111495: Add PyFile tests (#129449) (#129477) gh-111495: Add PyFile tests (#129449) Add tests for the following functions in test_capi.test_file: * PyFile_FromFd() * PyFile_GetLine() * PyFile_NewStdPrinter() * PyFile_WriteObject() * PyFile_WriteString() * PyObject_AsFileDescriptor() Remove test_embed.StdPrinterTests which became redundant. (cherry picked from commit 4ca9fc0) (cherry picked from commit 9a59a51)

vstinner · 2025-02-06T13:19:40Z

I close the issue. A lot of work has been done in this issue!

If someone wants to continue this work, I suggest to open new issues such as #117968.

Add tests for the following functions in test_capi.test_file: * PyFile_FromFd() * PyFile_GetLine() * PyFile_NewStdPrinter() * PyFile_WriteObject() * PyFile_WriteString() * PyObject_AsFileDescriptor() Add Modules/_testlimitedcapi/file.c file. Remove test_embed.StdPrinterTests which became redundant.

serhiy-storchaka added tests Tests in the Lib/test dir topic-C-API 3.12 only security fixes 3.13 bugs and security fixes labels Oct 30, 2023

serhiy-storchaka self-assigned this Oct 30, 2023

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Oct 30, 2023

pythongh-111495: Add tests for PyBytes and PyByteArray C API

9fbc7e4

bedevere-app bot mentioned this issue Oct 30, 2023

gh-111495: Add tests for PyBytes and PyByteArray C API #111496

Merged

rawwar mentioned this issue Oct 31, 2023

gh-111495: Add tests for PyList C API #111562

Merged

skirpichev added a commit to skirpichev/cpython that referenced this issue Nov 1, 2023

pythongh-111495: add stub files for test modules

c6cd397

This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue.

skirpichev added a commit to skirpichev/cpython that referenced this issue Nov 1, 2023

pythongh-111495: add stub files for C API test modules

d8fa0b0

This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue.

bedevere-app bot mentioned this issue Nov 1, 2023

gh-111495: add stub files for C API test modules #111586

Merged

skirpichev added a commit to skirpichev/cpython that referenced this issue Nov 1, 2023

pythongh-111495: Add tests for PyComplex C API

637b759

serhiy-storchaka pushed a commit that referenced this issue Nov 1, 2023

gh-111495: add stub files for C API test modules (GH-111586)

33ed5fa

This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue.

skirpichev added a commit to skirpichev/cpython that referenced this issue Nov 1, 2023

pythongh-111495: Add tests for PyComplex C API

b88f657

bedevere-app bot mentioned this issue Nov 1, 2023

gh-111495: Add tests for PyComplex C API #111591

Merged

bedevere-app bot mentioned this issue Nov 1, 2023

[3.12] gh-111495: add stub files for C API test modules (GH-111586) #111592

Merged

rawwar mentioned this issue Nov 1, 2023

gh-111495: Add tests for PyTuple C API #111606

Closed

serhiy-storchaka added a commit that referenced this issue Nov 1, 2023

gh-111495: Add tests for PyBytes and PyByteArray C API (GH-111496)

97b3cd3

Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024

pythongh-111495: Add tests for PyFloat C API (pythonGH-111624)

7795860

Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024

pythongh-111495: Add tests for PyComplex C API (pythonGH-111591)

7748a29

vstinner pushed a commit that referenced this issue Sep 5, 2024

[3.12] gh-111495: Add tests for PyNumber C API (GH-111996) (#123376)

1d8ab25

(cherry picked from commit 2f20f5a)

vstinner pushed a commit that referenced this issue Sep 29, 2024

gh-111495: Add tests for PyCodec_* C API (#123343)

6d0d26e

bedevere-app bot mentioned this issue Oct 3, 2024

gh-111495: Add tests for PyFile C API #124915

Closed

bedevere-app bot mentioned this issue Oct 27, 2024

gh-111495: improve test coverage of codecs C API #126030

Merged

encukou pushed a commit that referenced this issue Nov 1, 2024

gh-111495: improve test coverage of codecs C API (GH-126030)

32e07fd

For now, skip some crashers (tracked in gh-123378).

picnixz added a commit to picnixz/cpython that referenced this issue Dec 8, 2024

pythongh-111495: improve test coverage of codecs C API (pythonGH-126030)

629634a

For now, skip some crashers (tracked in pythongh-123378).

ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025

pythongh-111495: improve test coverage of codecs C API (pythonGH-126030)

2ea6baa

For now, skip some crashers (tracked in pythongh-123378).

vstinner added a commit to vstinner/cpython that referenced this issue Jan 18, 2025

pythongh-111495: Add more tests on PyEval C APIs (python#122789)

3c6bc1b

* Add Lib/test/test_capi/test_eval.py * Add Modules/_testlimitedcapi/eval.c (cherry picked from commit bf8b374)

vstinner added a commit to vstinner/cpython that referenced this issue Jan 18, 2025

pythongh-111495: Fix refleaks in test_capi.test_eval tests (python#12…

bd66480

…2851) (cherry picked from commit b4a3160)

vstinner mentioned this issue Jan 18, 2025

[3.13] gh-111495: Add more tests on PyEval C APIs (#122789) #128987

Merged

vstinner mentioned this issue Jan 19, 2025

[3.12] gh-111495: Add more tests on PyEval C APIs (#122789) (#128987) #129023

Merged

bedevere-app bot mentioned this issue Jan 29, 2025

gh-111495: Add PyFile tests #129449

Merged

bedevere-app bot mentioned this issue Jan 30, 2025

[3.13] gh-111495: Add PyFile tests (#129449) #129477

Merged

vstinner mentioned this issue Jan 31, 2025

[3.12] gh-111495: Add PyFile tests (#129449) (#129477) #129501

Merged

vstinner closed this as completed Feb 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more C API tests #111495

Add more C API tests #111495

serhiy-storchaka commented Oct 30, 2023 •

edited by bedevere-app bot

Loading

skirpichev commented Oct 31, 2023

serhiy-storchaka commented Oct 31, 2023

serhiy-storchaka commented Oct 31, 2023

skirpichev commented Oct 31, 2023

serhiy-storchaka commented Oct 31, 2023

rawwar commented Oct 31, 2023

serhiy-storchaka commented Oct 31, 2023

skirpichev commented Nov 1, 2023 •

edited

Loading

serhiy-storchaka commented Nov 1, 2023

sobolevn commented Nov 1, 2023

vstinner commented Jan 30, 2025

vstinner commented Feb 6, 2025

Add more C API tests #111495

Add more C API tests #111495

Comments

serhiy-storchaka commented Oct 30, 2023 • edited by bedevere-app bot Loading

Linked PRs

skirpichev commented Oct 31, 2023

serhiy-storchaka commented Oct 31, 2023

serhiy-storchaka commented Oct 31, 2023

skirpichev commented Oct 31, 2023

serhiy-storchaka commented Oct 31, 2023

rawwar commented Oct 31, 2023

serhiy-storchaka commented Oct 31, 2023

skirpichev commented Nov 1, 2023 • edited Loading

serhiy-storchaka commented Nov 1, 2023

sobolevn commented Nov 1, 2023

vstinner commented Jan 30, 2025

vstinner commented Feb 6, 2025

serhiy-storchaka commented Oct 30, 2023 •

edited by bedevere-app bot

Loading

skirpichev commented Nov 1, 2023 •

edited

Loading