-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-111495: Add tests for PyTuple C API #118757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
skirpichev
commented
May 8, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: Add more C API tests #111495
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Probably, could skip news:) It's #111606, with some minor fixes and tests for PyTuple_Pack, PyTuple_SetItem/PyTuple_SET_ITEM and PyTuple_Resize. Limited API C functions are moved to _testlimitedcapi/ directory. |
@rawwar, let me know if you are not OK with this using your code. |
Please reuse it. I am completely fine with it. |
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
* fix reference leak * add assert * revert arguments of tuple_resize()
I merged your PR, thanks @skirpichev! |
@vstinner, shouldn't this be backported to 3.12 and 3.13? |
|
|
|
|
|
I would prefer to not backport them. @serhiy-storchaka: What's your call on backporting new C API tests to stable branches? |
I prefer to backport tests as far as possible. This helps if we change the behavior in new version or backport bug fixes. |
Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @skirpichev and @vstinner, I could not cleanly backport this to
|
Sorry, @skirpichev and @vstinner, I could not cleanly backport this to
|
|
I'm working on backports. |
(cherry picked from commit dbc1752) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: kalyanr <kalyan.ben10@live.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
GH-123371 is a backport of this pull request to the 3.13 branch. |
3.12 is less trivial due to changes from #116417. I can do backport for current state of 3.12, but maybe it does make sense to backport first pr's from above issue? Or 3.12 not worth efforts at all? |
(cherry picked from commit dbc1752) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: kalyanr <kalyan.ben10@live.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
GH-123379 is a backport of this pull request to the 3.12 branch. |