Skip to content

Improve test_win32_ver in test_platform #116491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Mar 8, 2024 · 0 comments
Closed

Improve test_win32_ver in test_platform #116491

sobolevn opened this issue Mar 8, 2024 · 0 comments
Assignees
@sobolevn
Labels
OS-windows tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Mar 8, 2024 •
edited by bedevere-app bot
Loading

Bug report

Right now it looks like this:

cpython/Lib/test/test_platform.py

Lines 329 to 330 in 0b64714

def test_win32_ver(self):
res = platform.win32_ver()

Looks like this test was added as a part of this commit: c69d1c4 19 years ago.

And for some reason, win32_ver was never improved.
I will send a PR for this, however, I might need some help, because I don't have access to windows machine.

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir OS-windows labels Mar 8, 2024
@sobolevn sobolevn self-assigned this Mar 8, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue Mar 8, 2024
@sobolevn
pythongh-116491: Improve test_win32_ver
8001a10
@bedevere-app bedevere-app bot mentioned this issue Mar 8, 2024
Merged
sobolevn added a commit that referenced this issue Mar 13, 2024
@sobolevn
gh-116491: Improve test_win32_ver (#116506)
ee0dbbc
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 13, 2024
@sobolevn @miss-islington
pythongh-116491: Improve test_win32_ver (pythonGH-116506)
2bbb0f2 
(cherry picked from commit ee0dbbc)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 13, 2024
@sobolevn @miss-islington
pythongh-116491: Improve test_win32_ver (pythonGH-116506)
ff43b1b 
(cherry picked from commit ee0dbbc)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
This was referenced Mar 13, 2024
Merged
Merged
sobolevn added a commit that referenced this issue Mar 13, 2024
@miss-islington @sobolevn
[3.12] gh-116491: Improve test_win32_ver (GH-116506) (#116708)
9ef84b4 
gh-116491: Improve `test_win32_ver` (GH-116506)
(cherry picked from commit ee0dbbc)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit that referenced this issue Mar 13, 2024
@miss-islington @sobolevn
[3.11] gh-116491: Improve test_win32_ver (GH-116506) (#116709)
5bd3507 
gh-116491: Improve `test_win32_ver` (GH-116506)
(cherry picked from commit ee0dbbc)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
vstinner pushed a commit to vstinner/cpython that referenced this issue Mar 20, 2024
@sobolevn @vstinner
pythongh-116491: Improve test_win32_ver (python#116506)
78df8ba
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
@sobolevn @adorilson
pythongh-116491: Improve test_win32_ver (python#116506)
2829283
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@sobolevn @diegorusso
pythongh-116491: Improve test_win32_ver (python#116506)
ab8cf04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
OS-windows tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sobolevn