Skip to content

gh-116491: Improve test_win32_ver #116506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2024
Merged

gh-116491: Improve test_win32_ver #116506

merged 2 commits into from
Mar 13, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Mar 8, 2024 •
edited by bedevere-app bot
Loading

Any feedback is appreciated! It is rather hard to test a win-only function without having a windows machine :)

@sobolevn sobolevn added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 8, 2024
@sobolevn sobolevn requested review from zooba and a team March 8, 2024 18:21
@bedevere-app bedevere-app bot mentioned this pull request Mar 8, 2024
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Mar 8, 2024
zooba
zooba reviewed Mar 11, 2024
View reviewed changes
@sobolevn sobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 12, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 9345789 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 12, 2024
@sobolevn
Copy link
Member Author

These two buildbot failures are unrelated:

5 re-run tests:
    test.test_asyncio.test_ssl test_eintr test_gc test_math test_tools
2 tests failed:
    test_math test_tools

and:

1 test skipped (resource denied):
    test_zipfile64
3 re-run tests:
    test_datetime test_set test_tokenize
1 test failed:
    test_datetime

So, I think that it is fine to merge this test 🎉
Thanks a lot for the review.

@sobolevn sobolevn merged commit ee0dbbc into python:main Mar 13, 2024
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 13, 2024
@sobolevn @miss-islington
pythongh-116491: Improve test_win32_ver (pythonGH-116506)
2bbb0f2 
(cherry picked from commit ee0dbbc)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Mar 13, 2024

GH-116708 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 13, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 13, 2024
@sobolevn @miss-islington
pythongh-116491: Improve test_win32_ver (pythonGH-116506)
ff43b1b 
(cherry picked from commit ee0dbbc)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Mar 13, 2024

GH-116709 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 13, 2024
sobolevn added a commit that referenced this pull request Mar 13, 2024
@miss-islington @sobolevn
[3.12] gh-116491: Improve test_win32_ver (GH-116506) (#116708)
9ef84b4 
gh-116491: Improve `test_win32_ver` (GH-116506)
(cherry picked from commit ee0dbbc)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Mar 13, 2024
@miss-islington @sobolevn
[3.11] gh-116491: Improve test_win32_ver (GH-116506) (#116709)
5bd3507 
gh-116491: Improve `test_win32_ver` (GH-116506)
(cherry picked from commit ee0dbbc)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@sobolevn @vstinner
pythongh-116491: Improve test_win32_ver (python#116506)
78df8ba
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@sobolevn @adorilson
pythongh-116491: Improve test_win32_ver (python#116506)
2829283
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@sobolevn @diegorusso
pythongh-116491: Improve test_win32_ver (python#116506)
ab8cf04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @bedevere-bot @zooba