Skip to content

Improve class A[]: ... syntax error message #118090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Apr 19, 2024 · 1 comment
Closed

Improve class A[]: ... syntax error message #118090

sobolevn opened this issue Apr 19, 2024 · 1 comment
Assignees
@sobolevn
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@sobolevn
Copy link
Member

sobolevn commented Apr 19, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Right now it will generate this default error:

>>> class A[]: ...
  File "<stdin>", line 1
    class A[]: ...
            ^
SyntaxError: invalid syntax
>>> def some[](arg: int) -> None: ...
  File "<stdin>", line 1
    def some[](arg: int) -> None: ...
            ^
SyntaxError: expected '('
>>> type Alias[] = int
  File "<stdin>", line 1
    type Alias[] = int
               ^
SyntaxError: invalid syntax

I propose to change it to:

>>> class A[]:
  File "<stdin>", line 1
    class A[]:
            ^
SyntaxError: At least one type variable definition is expected
>>> def some[](arg: int) -> None: ...
  File "<stdin>", line 1
    def some[](arg: int) -> None: ...
             ^
SyntaxError: At least one type variable definition is expected

>>> type Alias[] = int
  File "<stdin>", line 1
    type Alias[] = int
               ^
SyntaxError: At least one type variable definition is expected

I have a PR ready.

Linked PRs
@sobolevn sobolevn added type-feature A feature request or enhancement interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Apr 19, 2024
@sobolevn sobolevn self-assigned this Apr 19, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue Apr 19, 2024
@sobolevn
pythongh-118090: Improve error message for empty type param brackets
8072385
@bedevere-app bedevere-app bot mentioned this issue Apr 19, 2024
Merged
encukou pushed a commit that referenced this issue May 7, 2024
@sobolevn
gh-118090: Improve error message for empty type param brackets (GH-11…
b60d4c0 
…8091)
SonicField pushed a commit to SonicField/cpython that referenced this issue May 8, 2024
@sobolevn @SonicField
pythongh-118090: Improve error message for empty type param brackets (p…
3102a02 
…ythonGH-118091)
@wookie184
Copy link
Contributor

It looks like this was fixed, can this be closed @sobolevn?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolevn @wookie184