Skip to content

Wrap some multi-line macros in do { ... } while(0) in {codegen,compile}.c #120017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
picnixz opened this issue Jun 4, 2024 · 2 comments
Closed

Wrap some multi-line macros in do { ... } while(0) in {codegen,compile}.c #120017

picnixz opened this issue Jun 4, 2024 · 2 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@picnixz
Copy link
Member

picnixz commented Jun 4, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

Follow-up from the following observation (I'm sending a PR just after):

There are similar patterns in compile.c, maybe it is also worth taking a look? 🤔

Originally posted by @sobolevn in #119981 (comment)

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs
@picnixz picnixz added the type-feature A feature request or enhancement label Jun 4, 2024
@bedevere-app bedevere-app bot mentioned this issue Jun 4, 2024
Merged
@picnixz

This comment was marked as outdated.

Sign in to view
@picnixz picnixz mentioned this issue Jun 18, 2024
Closed
@picnixz picnixz changed the title Wrap some multi-line macros in do { ... } while(0) in compile.c Wrap some multi-line macros in do { ... } while(0) in codegen.c Nov 7, 2024
@picnixz picnixz changed the title Wrap some multi-line macros in do { ... } while(0) in codegen.c Wrap some multi-line macros in do { ... } while(0) in {compile,codegen}.c Nov 7, 2024
@picnixz picnixz changed the title Wrap some multi-line macros in do { ... } while(0) in {compile,codegen}.c Wrap some multi-line macros in do { ... } while(0) in {codegen,compile}.c Nov 7, 2024
@picnixz picnixz added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Nov 7, 2024
iritkatriel pushed a commit that referenced this issue Nov 7, 2024
@picnixz
gh-120017: use 'do-while(0)' in some {codegen,compile}.c multi-line…
c222441 
… macros (#120018)
@picnixz
Copy link
Member Author

picnixz commented Nov 8, 2024

Closing since it was completed. I won't backport it since I didn't backport the others.

@picnixz picnixz closed this as completed Nov 8, 2024
picnixz added a commit to picnixz/cpython that referenced this issue Dec 8, 2024
@picnixz
pythongh-120017: use 'do-while(0)' in some {codegen,compile}.c mult…
392db1a 
…i-line macros (python#120018)
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@picnixz @ebonnal
pythongh-120017: use 'do-while(0)' in some {codegen,compile}.c mult…
0dffd44 
…i-line macros (python#120018)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@picnixz