Skip to content

weakrefobject.c doesn't handle allocate_weakref failures #121652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
colesbury opened this issue Jul 12, 2024 · 0 comments
Closed

weakrefobject.c doesn't handle allocate_weakref failures #121652

colesbury opened this issue Jul 12, 2024 · 0 comments
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@colesbury
Copy link
Contributor

colesbury commented Jul 12, 2024 •
edited by bedevere-app bot
Loading

Bug report

We need to handle the case where allocate_weakref returns NULL due to an out-of-memory error.

cpython/Objects/weakrefobject.c

Lines 428 to 439 in dc03ce7

PyWeakReference *newref = allocate_weakref(type, obj, callback);
insert_weakref(newref, list);
UNLOCK_WEAKREFS(obj);
return newref;
}
else {
// We may not be able to safely allocate inside the lock
PyWeakReference *newref = allocate_weakref(type, obj, callback);
LOCK_WEAKREFS(obj);
insert_weakref(newref, list);
UNLOCK_WEAKREFS(obj);
return newref;

Linked PRs
@colesbury colesbury added type-bug An unexpected behavior, bug, or error 3.13 bugs and security fixes 3.14 bugs and security fixes labels Jul 12, 2024
colesbury added a commit to colesbury/cpython that referenced this issue Jul 12, 2024
@colesbury
pythongh-121652: Handle allocate_weakref returning NULL
4e5f82c 
The `allocate_weakref` may return NULL when out of memory. We need to
handle that case and propagate the error.
@bedevere-app bedevere-app bot mentioned this issue Jul 12, 2024
Merged
@Eclips4 Eclips4 added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Jul 13, 2024
colesbury added a commit that referenced this issue Jul 13, 2024
@colesbury
gh-121652: Handle allocate_weakref returning NULL (#121653)
a640a60 
The `allocate_weakref` may return NULL when out of memory. We need to
handle that case and propagate the error.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 13, 2024
@colesbury @miss-islington
pythongh-121652: Handle allocate_weakref returning NULL (pythonGH-1…
8526cc4 
…21653)

The `allocate_weakref` may return NULL when out of memory. We need to
handle that case and propagate the error.
(cherry picked from commit a640a60)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Jul 13, 2024
Merged
colesbury added a commit that referenced this issue Jul 13, 2024
@miss-islington @colesbury
[3.13] gh-121652: Handle allocate_weakref returning NULL (GH-121653) (
f78e1aa 
#121721)

The `allocate_weakref` may return NULL when out of memory. We need to
handle that case and propagate the error.
(cherry picked from commit a640a60)

Co-authored-by: Sam Gross <colesbury@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@colesbury @estyxx
pythongh-121652: Handle allocate_weakref returning NULL (python#121653
9f1b51e 
)

The `allocate_weakref` may return NULL when out of memory. We need to
handle that case and propagate the error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colesbury @Eclips4